Repository navigation
Declare the packages firecrown and its pip-installed packages use - #693
Merged
Merged
Conversation
vitenti
commented
Oct 23, 2026
vitenti
commented
Collaborator
- Behavior change: firecrown installs no longer pull in astropy and fitsio, which nothing in firecrown imports; install them separately if needed
- Remove astropy, used only by the example scripts deleted in Move the cluster examples into firecrown examples and remove FIRECROWN_DIR #689
- Declare clmm and pydantic-core in runtime, since firecrown imports both
- Remove the workarounds nothing imports: charset-normalizer, idna, urllib3, cython, fitsio, more-itertools and fuzzywuzzy
- Declare the requirements of cobaya and isitgr, installed from PyPI: dill, getdist, packaging, pandas, portalocker, pybobyqa, rapidfuzz, requests, sympy and tqdm
- Keep tabulate as a workaround: numcosmo_py's CLI imports it, but conda-forge's numcosmo 0.28.0 does not declare it
- Take build from conda-forge as python-build instead of PyPI, and move types-pyyaml to devenv
- Re-solve the lockfiles: 70 to 71 packages fewer per environment; pip installs cobaya, isitgr and py-bobyqa, plus mpmath on Python 3.14
- Known limitation: py-bobyqa, and mpmath on Python 3.14, still come from PyPI over conda's copies; the PyPI-to-conda name mapping has no py-bobyqa entry, and sympy 1.14's PyPI metadata requires mpmath <1.4 while conda-forge's sympy allows <1.5
- Checked locally with the py3.14 lock: make deps-check, the CosmoSIS standard library build, 4299 unit tests and all 81 example runs
* Behavior change: firecrown installs no longer pull in astropy and fitsio, which nothing in firecrown imports; install them separately if needed * Remove astropy, used only by the example scripts deleted in #689 * Declare clmm and pydantic-core in runtime, since firecrown imports both * Remove the workarounds nothing imports: charset-normalizer, idna, urllib3, cython, fitsio, more-itertools and fuzzywuzzy * Declare the requirements of cobaya and isitgr, installed from PyPI: dill, getdist, packaging, pandas, portalocker, pybobyqa, rapidfuzz, requests, sympy and tqdm * Keep tabulate as a workaround: numcosmo_py's CLI imports it, but conda-forge's numcosmo 0.28.0 does not declare it * Take build from conda-forge as python-build instead of PyPI, and move types-pyyaml to devenv * Re-solve the lockfiles: 70 to 71 packages fewer per environment; pip installs cobaya, isitgr and py-bobyqa, plus mpmath on Python 3.14
|
PR revision: No breaking API changes detected. PR public API verdictNo breaking API changes detected. Target: Static analysis only: no behavioral compatibility guarantee or external-dependency signature analysis. Public API changes: 084427d -> HEADExecutive summaryNo breaking API changes detected. Breaking changesNone. New public APINone. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #693 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 163 163
Lines 9978 9978
Branches 1199 1199
=======================================
Hits 9978 9978 🚀 New features to boost your workflow:
|
marcpaterno
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.