Repository navigation
Apply the v1.16.1 fixes to master - #692
Merged
Merged
Conversation
|
PR revision: No breaking API changes detected. PR public API verdictNo breaking API changes detected. Target: Static analysis only: no behavioral compatibility guarantee or external-dependency signature analysis. Public API changes: 2568be3 -> HEADExecutive summaryNo breaking API changes detected. Breaking changesNone. New public API
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 163 163
Lines 9977 9978 +1
Branches 1199 1199
=======================================
+ Hits 9977 9978 +1
🚀 New features to boost your workflow:
|
* Build the cosmology with prim= and reion= in _numcosmo.py instead of add_submodel * Fix Yp with NcBBNParametrized in the test fixtures and call set_z_from_tau(tau) * Pass submodels to the constructors in the remaining NumCosmo tests and cluster examples * Raise the numcosmo pin to >=0.28,<1.0 in dependencies.yaml, environment.yml and pyproject.toml
* Pin CosmoSIS to `<3.26` because 3.26 ships Fortran module files built with gfortran 15, while the current `camb <2.0` constraint keeps Firecrown's build environment on gfortran 14 * Update intermediate likelihood and statistic classes for pylint 4.1 abstract-class detection * Move `SourceGalaxy.tracer_args` annotation to the class body so pylint recognizes the attribute declaration * Override unsupported `StudentT.make_realization_vector` behavior explicitly and add coverage for it * Replace the incomplete likelihood test helper with a concrete implementation while testing the base default directly * Normalize SciPy count and bin-edge outputs to `float64` for scipy-stubs compatibility * Verify mypy, pylint, black, flake8, affected tests, and the CosmoSIS standard-library build
* Compute `min_ell` and `max_ell` in `TwoPointTheory.generate_ells_for_interpolation` with `np.min`/`np.max` instead of `self.ells[0]`/`self.ells[-1]` * Fix pylint E1136 (unsubscriptable-object) on `self.ells`, reported when the pylint worker checking `_theory.py` has not analyzed `firecrown/likelihood/_two_point.py`, where `ells` is assigned
* Re-solve the lockfiles with master's manifest: the v1.16.1 versions plus griffe from #680 * Regenerate environment.yml with pygobject-stubs <2.18
* Create HICosmoDEXcdm with prim and reion in _cluster_data._numcosmo_cosmology instead of attaching them with add_submodel, deprecated in NumCosmo 0.28
vitenti
force-pushed
the
apply-v1.16.1-fixes-to-master
branch
from
October 23, 2026 12:11
092db9a to
640d1c3
Compare
marcpaterno
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.