Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Existing outputs in refuse mode now cause dry runs and flow-chart generation to fail during initialization.
1 open finding
What changed in this PR
Updates dry-run previews to identify stages that could be skipped.
Changes:
- Tracks commands and completed stage names separately.
- Prints completion notices after the command list.
| File | Description |
|---|---|
ceci/pipeline/dry_run.py |
Adds completion checks and reporting to dry runs. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change preserves existing command output, with only a non-blocking regression-test suggestion remaining.
1 open finding
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+37
to
+38
| if self.run_config["resume"] in (True, "resume") and super().should_skip_stage(stage): | ||
| self.run_info["completed_stages"].append(stage.instance_name) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.