Repository navigation
Set NUMBA_NUM_THREADS as well as OMP_NUM_THREADS - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes consistently mirror the existing OpenMP configuration, with no unresolved findings.
Review effort: Balanced
Findings: None
What changed in this PR
Configures Numba’s thread limit alongside OpenMP’s in the site command builders.
Changes:
- Sets
NUMBA_NUM_THREADSfromthreads_per_processfor native and container commands. - Adds command assertions for local, Docker, and NERSC execution.
| File | Description |
|---|---|
| tests/test_cmd.py | Checks the Numba thread setting in generated commands. |
| ceci/sites/nersc.py | Adds the setting to native and Shifter commands. |
| ceci/sites/local.py | Adds the setting to native and Docker commands. |
| ceci/sites/ccin2p3.py | Adds the setting to native and Singularity commands. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.