Repository navigation
Tighten flow charts more - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new test passes a NetworkX graph to a PyGraphviz-specific helper, causing an AttributeError before its assertions.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Makes pipeline flow charts more compact by combining eligible input nodes.
Changes:
- Groups input nodes with no predecessors and the same sole successor.
- Integrates grouping into flow-chart generation and replaces
nodes_iter()withnodes(). - Adds a test for input-node merging.
| File | Description |
|---|---|
tests/test_graph.py |
Adds an input-node merging test. |
ceci/pipeline/pipeline.py |
Applies input grouping and updates node iteration. |
ceci/pipeline/graph.py |
Implements input grouping and updates output-node iteration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines input nodes that can all be put together in a plot.
Also apparently the networkx method nodes_iter has been removed in more recent versions and been replaced with just nodes, which now returns a view. This shouldn't matter for older versions where nodes() returns a list, since we are dealing with small graphs here so there will be no memory issues.