Repository navigation
Allow jinja templates in config as well as pipeline files - #136
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Template parameters are not propagated to stage configurations or the ancestors tool.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds Jinja rendering to stage configuration loading and related pipeline utilities.
Changes:
- Renders stage configuration files before YAML parsing.
- Updates tests and fixtures to exercise Jinja syntax.
- Makes template execution tests safely rerunnable.
| File | Description |
|---|---|
ceci/stage.py |
Renders configuration before stage initialization. |
ceci/pipeline/pipeline.py |
Renders pipeline-level stage configuration. |
ceci/tools/ancestors.py |
Renders pipeline files in the ancestors tool. |
tests/config.yml |
Adds Jinja-based test configuration. |
tests/test_pipeline.py |
Uses template-aware loading. |
tests/test_flow_chart.py |
Uses template-aware loading. |
tests/test_executables.py |
Cleans generated directories before reruns. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eacharles
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier changes allowed us to use Jinja2 templates in pipeline files. This change extends that to stage configuration files too.
Currently, template parameters are not allowed in config files, so only loops and similar features are useful. We may look at this again, but it would be a bit messy on the command line.
I also updated a test to fix a problem when it was re-run.