Repository navigation
diagnose Limber integration stability - #1313
Open
nikosarcevic wants to merge 1 commit into
Open
nikosarcevic wants to merge 1 commit into
nikosarcevic wants to merge 1 commit into
Conversation
Coverage Report for CI Build 37088652479Coverage remained the same at 97.471%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Following up from the Slack thread: while comparing NumCosmo's angular power spectra with CCL's, we (the NumCosmo side) ran into the same QAG false convergence discussed here, and tested the fixes proposed in this PR. The results are below, in case they're useful.
Happy to share more details or the scripts if that would help. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR investigates a numerical instability in the Limber
qag_quadintergation that can produce an isolated discontinuous outlier while GSL QAG reports successful convergenceFor the reproducing case, the QAG result was wrong by approximately 4% despite returning
GSL_SUCCESS, so the existing CQUAD fallback was not triggered.This PR:
cquadas an explicit Libmer integration option for comparisonfor the pathological point, the QAG local residual decreases from approx
4.0e-2to7.2e-6.the corrected result agrees with CQUAD and an independently converged Simpson integration.
The existing
pyccl/tests/test_cells.pysuite passes (16 passed).This is intended primarily to document and reproduce the issue and test a possible mitigation; the split-QAG implementation is not necessarily intended as the final solution.