Translate /blossom-server-hosting into all 10 locales - #98
Merged
Conversation
Signed-off-by: v0l <kieran@harkin.me>
Signed-off-by: v0l <kieran@harkin.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97.
20 of 35 message ids on this page were byte-identical to English in every one of the 10 non-English locale files — lede, FAQ, cards, meta description, all English regardless of visitor locale. Found while checking a stale worktree (
feat/blossom-landing-page, PR #56, closed unmerged) for cleanup.en.jsonmatches current main's for each id before copying, so no translation is attached to text it wasn't written for. chore(i18n): translate the Blossom landing page and fix the INVALID_TAG build break #56's own review already fixed the two defects it found (an<a>attribute the model added, breakingformatjs compile-folder, and "Route96" getting translated) — placeholder/tag equality checked programmatically across all 10 locales × 20 ids post-merge, all match.xUdVjn, the bare word "Route96") wasn't in chore(i18n): translate the Blossom landing page and fix the INVALID_TAG build break #56 at all — translated fresh viaollama_intl. First pass turned it into "the game Route96" in Arabic; regenerated once, second pass is in the right domain (no re-review possible past that, not fluent in Arabic).Verified server-rendered, not just the JSON:
bun server/prod.ts+curl -H "Accept-Language: de/ru/ja/zh"on/blossom-server-hosting— real translated<title>/<h1>/lede, "Route96" preserved as a brand name in all four.bun test44 pass,tsc --noEmitclean, build clean at 55f641a.