Custom VM orders: choose IPv4/IPv6 count - #93
Merged
Conversation
Signed-off-by: v0l <kieran@harkin.me>
Signed-off-by: v0l <kieran@harkin.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
Depends on api#105 (LNVPS/api#339, not merged yet) — do not merge before that lands, the endpoints don't accept/return these fields until it does.
src/api.ts:250-253,271-272,299-300—min_ip4/max_ip4/min_ip6/max_ip6onVmCustomTemplateParams,ip4_count/ip6_countonVmCustomTemplateRequestandVmTemplate.src/components/vps-custom.tsx— IPv4/IPv6 sliders next to CPU/memory/storage, same min/max pattern; hidden when a template has no range to offer. Wired into the live price quote and the order spec.src/pages/order/vm.tsx:59-60— the chosen counts actually reachorderCustom, not just the quote.src/components/vps-resources.tsx— order-review line and VM cards show the count when it's not the boring default (>1 IPv4, any IPv6).Built against the contract Bojan posted in general — can't verify end to end until api#105 merges.
Known at merge time: api#105 caps
max_ip4/max_ip6at 1 (Proxmox's single-NICipconfig0can't carry a second address yet, api#343 lifts it), so both sliders stay hidden until that cap is lifted. Confirmed correct behaviour, not a bug — flagged by Goran in general.