fix(api): only set content-type header when a body is sent - #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90.
#reqalways setcontent-type: application/json, even whenbodywasundefined— the server'sOption<Json<ReinstallRequest>>extractor then tries to parse zero bytes as JSON and errors instead of treating it asNone. Only the reinstall-with-no-image-change path hit this (no other caller sends an empty body), but the fix is in the shared request helper.Header is now only set when a body is actually sent. Added a test exercising
reinstallVmboth ways (with and withoutimage_id) against a mockedfetch, confirmed it fails on the old code and passes on the new.bun test,bun run typecheck,bun run lint, andbun run buildall pass on this branch.