Add Duplicate (Notes) Over action+shortcut in Piano Roll#8447
Open
JJCUBER wants to merge 1 commit into
Open
Conversation
Create Duplicate Over Action icon
Member
|
Potentially related? #7873 |
Author
|
Ah yeah that does seem pretty similar, though some of the additions differ from the additions I proposed at the bottom of my pr. Annoyingly, that did not show up when I searched (not to mention, GitHub likes to search by individual tokens anywhere in an issue/pr, so search queries have to be overly specific and accurate to find anything). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the feature requested in #1876 which got put within a list in #1488 then moved to #4877 for improving UI/UX workflow.
Having a selection in the piano role then selecting this action or using
Ctrl+Dclones the notes in the selection and places them just past the end of the selection. Having no selection instead duplicates everything over (similar to how commands for moving notes move all of them when nothing is selected). The new notes become selected (and the old notes become unselected), allowing for quickly chainingCtrl+Dan arbitrary number of times.In one of the aforementioned issues, there was discussion pertaining to potentially placing the notes at the end of all notes instead of just the selection as the default behavior. I am open to modifying the code to that if it is desired; however, I think the one I selected is a more sane default, as repeating what is selected should logically only care about itself, not the unrelated notes in the piano roll (e.g., if you have some arpeggio chord you want to repeat alongside your other notes and/or want to repeat then shift down). In fact, it would likely be better to potentially add three different actions (since the code for each changes only one line of logic):
Let me know what you think about the above and I can change anything as needed.