Add libgig support, fix VST time sync, and improve build scripts#8433
Open
Densyakun wants to merge 6 commits into
Open
Add libgig support, fix VST time sync, and improve build scripts#8433Densyakun wants to merge 6 commits into
Densyakun wants to merge 6 commits into
Conversation
- Fix WinMM linking: use 'winmm' for MinGW, keep hardcoded path for MSVC - Skip windeployqt POST_BUILD when cross-compiling - Pass VCPKG_APPLOCAL_DEPS flags to RemoteVstPlugin32 ExternalProject - Add missing target_link_directories for GigPlayer - Remove libgig from vcpkg (incompatible with MinGW, use PPA package) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Three bugs fixed: 1. Stop position not reflected to VST: When playback stops and returns to the start position, the VST plugin now sees the updated position. Previously, samplePos was only updated during playback. 2. Position changes while stopped: When the user moves the playback cursor without playing, the VST sync position is now updated via a connection to Timeline::positionJumped. 3. Piano roll (MidiClip) playback: playMidiClip() now calls setPlaybackState(true) like playSong() and playPattern() do. Additionally, samplePos in audioMasterGetTime is now derived from the computed ppqPos for consistency, rather than from the stale m_currentSamplePos that was only updated during process(). Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
When audioMasterGetTime is called while stopped and the position hasn't changed, neither the position-update branch nor the interpolation branch fires, leaving ppqPos at 0 (from memset). Add an else branch that preserves lastppqPos so the VST always sees the correct position regardless of playback state. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.