Prevent Sf2Intrument from trying to load non-existing file on deserialization#8432
Open
Itreza2 wants to merge 2 commits into
Open
Prevent Sf2Intrument from trying to load non-existing file on deserialization#8432Itreza2 wants to merge 2 commits into
Itreza2 wants to merge 2 commits into
Conversation
Itreza2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8430
When deserializing, in
Sf2Instrument::loadSettings, the sf2 instrument is trying to load its source .sf2 file, even if there no such file was loaded when the instrument was serialized. This is what is causing #8430.This PR is a adding a simple check in
Sf2Instrument::loadSettings:If the "src" attribute of the serialized object is an empty string, the method
Sf2Instrument::openFileisn't called.