Closes #239 Adding diffs to tests - #315
Open
elbashandy wants to merge 1 commit into
Open
Conversation
test diff has beed added to all mentioned alg tests. cf_reader cxx & python tests were failing with cam5 as it was diffing one of 2 time step overwritten outputs with one of the time step inputs
elbashandy
force-pushed
the
support_test_diffs
branch
from
December 18, 2019 20:09
b7bc6f4 to
0da92f5
Compare
burlen
requested changes
Jan 24, 2020
burlen
left a comment
burlen
left a comment
Collaborator
There was a problem hiding this comment.
the comment in PR says that two tests are failing, if this is the case then these should be fixed prior to merge. please update the comment when all tests pass.
burlen
reviewed
Jan 24, 2020
| input_data[0]); | ||
|
|
||
| std::cerr << "teca_cartesian_mesh_writer::execute -- mesh: " << mesh << std::endl; | ||
|
|
Collaborator
There was a problem hiding this comment.
please remove any debug code such as this cerr output
burlen
reviewed
Jan 24, 2020
| wri.set_file_name(out_file) | ||
| wri.set_executive(exe) | ||
|
|
||
| wri.update() No newline at end of file |
Collaborator
There was a problem hiding this comment.
fix no new line. note the red icon at the end of the above line.
burlen
reviewed
Jan 24, 2020
| teca_system_interface::set_stack_trace_on_error(); | ||
|
|
||
| if (argc < 7) | ||
| if (argc < 5) |
Collaborator
There was a problem hiding this comment.
this looks wrong to me. the argument parsing code below will crash if argc < 7. at least one array is expected
Collaborator
|
also for please add serial, mpi, threads and mpi_threads for parallel applications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test diff has beed added to all mentioned alg tests. cf_reader cxx & python tests are failing (cam5 test in cxx)