fix: fill schema defaults on current partial before diffing - #2234
Open
VarunAthreya wants to merge 2 commits into
Open
VarunAthreya wants to merge 2 commits into
VarunAthreya wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
+ Coverage 36.02% 36.06% +0.03%
==========================================
Files 82 82
Lines 7844 7844
==========================================
+ Hits 2826 2829 +3
+ Misses 4750 4748 -2
+ Partials 268 267 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@VarunAthreya as a rule of thumb - let's add integration tests in decK for any bugs. |
VarunAthreya
force-pushed
the
fix/partial-diff-schema-defaults
branch
from
September 18, 2026 05:43
3e0cd6f to
d93eae5
Compare
VarunAthreya
force-pushed
the
fix/partial-diff-schema-defaults
branch
from
September 18, 2026 05:44
d93eae5 to
dc0316f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill schema defaults on partials before diffing, preventing spurious update diffs.
Fixes Issue: #2199
Corresponding GDR PR: Kong/go-database-reconciler#527