fix: disable old pull_request_target validate-pull.yml on master too - #1743
Closed
badja-dev wants to merge 1 commit into
Closed
fix: disable old pull_request_target validate-pull.yml on master too#1743badja-dev wants to merge 1 commit into
badja-dev wants to merge 1 commit into
Conversation
|
Pull Requests cannot be submitted to master. Please resubmit the Pull Request to the develop branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Refs #1742
What type of PR is this?
Description
pull_request_targetreads its workflow definition from the repo's default branch, which for Quickstart ismaster, not from the PR's base branch. #1742 disabledvalidate-pull.yml'spull_request_targettrigger ondevelop, but that never took effect forpull_request_targetevents, sincemasterstill had the original file.Confirmed this live on #1738. The old workflow's
Format Code and Add Part Filejob ran and pushed an unrequestedPartbump commit straight to that contributor's branch, using the App token with write access, the exact behaviour this whole change is meant to stop.This applies the same one-line fix used in #1742 to
master.validate-pull.yml's trigger changes frompull_request_targettoworkflow_dispatch, and the comment is updated to make clear thatworkflow_dispatchhere is a placeholder to keep the file registered, not a working manual trigger (github.event.pull_requestis undefined forworkflow_dispatch). A real rollback means restoring thepull_request_targettrigger, not running this via the Actions tab.