Use normal index deletion for child nodes - #229
Open
CodingFeng101 wants to merge 1 commit into
Open
CodingFeng101 wants to merge 1 commit into
CodingFeng101 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dom_tag.delete_attribute()now deletes child nodes with normal list index semantics when the key is an integer.Why
Child reads and assignments already use normal list indexing: negative indexes work, and out-of-range indexes raise. Deletion was the odd path because it used a slice (
key:key+1), which madedel tag[10]silently do nothing and madedel tag[-1]fail to remove the last child.This keeps attribute deletion unchanged and only changes the integer child-index path.
Validation
del div("a", "b")[10]did not raise, anddelete_attribute(-1)did not remove the last child.python -m pytest tests\test_dom_tag.py::test_delete_attribute_child_index tests\test_dom_tag.py::test_set_attribute tests\test_html.py::test_add -qpython -m pytest tests -qpython -m py_compile dominate\dom_tag.py tests\test_dom_tag.pygit diff --checkNote: the repository-wide
python -m pytest -qalso collects README doctests locally; that currently fails on README doctest context setup (dis not defined), while the package test suite undertestspasses.