Repository navigation
Log whether a donut drag ended in a drop, and why a drop didn't convert (#784) - #785
Merged
Merged
Conversation
A drag that ends on a lit slice without converting (#784, macOS 13) left the same log line whether the system delivered the drop or ended the drag with a leave, and Convert closed the donut silently when no preset or no file fit. The summary line now says "left without a drop" for a leave, Convert logs why it closed without converting, and tool slices log that they opened, so the next log tells the cases apart. Refs #784 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds diagnostics for #784. On macOS 13, a drag sometimes ends on a lit slice and nothing converts. Today the log can't tell why. Three log lines change:
Drag over the donut: …ends with, left without a dropwhen the drag ended with a leave instead of a drop.RadialWindowraises the summary from bothOnDragLeaveandOnDrop, so until now the two looked the same.The donut closed without converting: …is new. It says whyConvertclosed the donut without converting: no preset at the slice, none of the files fit the preset, or the browser drop behind the files is gone.Opening <preset> for N file(s)is new, for tool slices such as Edit pictures. Before, they logged nothing after the drop.No behaviour changes; only these log lines are new or changed.
Type of change
How was it tested?
dotnet build src/Filee.App(0 errors)Refs #784
🤖 Generated with Claude Code