Repository navigation
fix(windows): focus donut for context-menu keyboard input (#730) - #734
Merged
KnifeLemon merged 2 commits intoOct 29, 2026
Merged
Conversation
…#730) Fixes KnifeLemon#730. When Filee was launched from the Windows Explorer or Desktop context menu, the donut window was activated but no control received keyboard focus. As a result, pressing Tab was not routed to DonutMenu.HandleKey and could not switch to the second face of the donut. This change: - makes DonutMenu focusable; - focuses the donut only in click mode; - keeps drag-and-drop mode unchanged so Explorer does not lose focus; - adds a regression test for Tab navigation in click mode.
DonutMenu.cs, RadialController.cs and RadialControllerTests.cs were added at the repository root next to the unchanged originals, so the build never saw the change. They now replace src/Filee.App/Controls/DonutMenu.cs, src/Filee.App/Services/RadialController.cs and tests/Filee.App.Tests/RadialControllerTests.cs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KnifeLemon
approved these changes
Oct 29, 2026
KnifeLemon
left a comment
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thanks, @Marouane-elfadli! The fix is right: the click-mode donut had no focused control after a context-menu launch, so Tab never reached HandleKey.
The three files had been added at the repository root next to the originals, so the build never compiled them. I moved them into src/Filee.App/Controls, src/Filee.App/Services and tests/Filee.App.Tests (9bd6378) and CI, including your new test, passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #730.
When Filee was launched from the Windows Explorer or Desktop context menu, the donut window was activated but no control received keyboard focus. As a result, pressing Tab was not routed to DonutMenu.HandleKey and could not switch to the second face of the donut.
This change:
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:Example:
fix(hwp): keep tables when converting to DOCXWhat does this change?
Type of change
How was it tested?
dotnet format --verify-no-changesdotnet testScreenshots (UI changes)
Checklist
src/Filee.App/Assets/i18n/*.jsonfilesTHIRD-PARTY-NOTICES.md