Skip to content

test(setup): check a language switch through ApplyLook shows the new texts (#667) - #723

Merged
KnifeLemon merged 1 commit into
mainfrom
test/667-apply-look-path
Oct 28, 2026
Merged

KnifeLemon merged 1 commit into
mainfrom
test/667-apply-look-path

Conversation

@SeoJCalive

Copy link
Copy Markdown
Collaborator

What does this change?

Follow-up to #667 / #692, as agreed in #667 (comment). Test only, no code change.

A_language_switch_through_apply_look_shows_the_new_texts (SetupTextsTests, [AvaloniaFact]) goes through the real App.ApplyLook: after SetLanguage("ko"), both the app resource installer.install and a TextBlock bound to it in a shown window show the Korean text, and the switch raises at most 10 resource changes.

The bound is a range (1 to 10), not an exact 4, as you suggested: the texts are one change, and the font (1) and flow direction (2) changes don't grow with the number of keys. With one write per key the count is over a thousand. The test starts from English and puts English back in finally, since the test assembly shares one app.

Type of change

  • Bug fix
  • New feature or improvement
  • New format or engine
  • Translation
  • Documentation
  • Build, CI or dependencies

Tests only.

How was it tested?

  • dotnet format --verify-no-changes
  • dotnet test: SetupTextsTests 61 passed, 1 skipped. Forcing Publish back to one write per key fails the new test with 1231 changes.
  • Tried it in the app (what you converted or clicked, and on which OS):

Full Filee.Setup.Tests on Linux (Release): 145 passed, 1 skipped, 52 failed. The same 52 tests fail by name on main on this PC (Windows-only installer, registry and kernel32.dll tests, and SetupWindowTests width checks); the Windows CI build job covers them. The new test passes.

Screenshots (UI changes)

No UI change.

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files (none)
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md (none)
  • The PR does one thing (unrelated changes go in a separate PR)

…texts

Follow-up to #667 / #692. Through the real App.ApplyLook, SetLanguage("ko")
changes both the app resource and a bound TextBlock in a shown window, and
the switch raises at most 10 resource changes: one for the texts plus the
fixed font and flow-direction changes, none of which grows with the number
of keys. One write per key fails it with over a thousand.
@SeoJCalive

Copy link
Copy Markdown
Collaborator Author

@KnifeLemon #667에서 말씀하신 ApplyLook 경로 시험을 이 PR로 올렸어요. 알림 수는 정확히 4 대신 10번 이하인지만 확인해요.

이슈 닫는 것에 대해 하나 여쭤볼게요.

  1. 제가 맡은 이슈: PR에 Closes #N을 쓰면 머지할 때 닫히니 따로 할 일은 없는데요. #540처럼 PR이 Refs로만 연결됐지만 목표를 이룬 경우에는, 근거와 남은 일을 댓글로 적고 제가 직접 닫아도 될까요?
  2. 다른 분이 올린 제보: #523처럼 이미 고쳐진 경우에는, 고친 PR과 들어갈 릴리스만 알려 드리고 닫는 건 지금처럼 맡겨 드리면 될까요? 아니면 명확히 해결된 문제일 경우 다음 릴리즈에서 확인 부탁하고 직접 닫아도 될까요?

이슈 정리에 대한 개인적인 의견이라 편하신 방식 알려 주시면 그대로 할게요.

@KnifeLemon KnifeLemon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SeoJCalive! Going through the real ApplyLook with a bound TextBlock checks what a user actually sees, and the 1–10 range keeps it from breaking when one more fixed resource is added. Putting English back in finally is right, since the test app is shared. I'll merge once the Windows build is green.

@KnifeLemon
KnifeLemon merged commit 8f48222 into main Oct 28, 2026
9 checks passed
@KnifeLemon

Copy link
Copy Markdown
Owner

@SeoJCalive 머지하면서 질문을 놓쳤네요, 늦게 답해서 미안해요. 둘 다 직접 닫으셔도 돼요.

  1. 맡은 이슈를 Refs로 연결한 PR이 해결한 경우: 네, 직접 닫아 주세요. 닫을 때 댓글에 이 두 가지만 적어 주세요.
    • 근거: 어느 PR로, 무엇을 확인했는지
    • 남은 일: 남은 게 있으면 새 이슈로 따로 열고 링크해 주세요. 남은 일이 있는 이슈를 열어 두지는 않아요.
  2. 다른 분이 올린 제보가 이미 고쳐진 경우: 고친 PR이 머지됐고 제보 내용과 확실히 같은 문제라면 직접 닫아도 돼요. 댓글에 고친 PR과 들어간(또는 들어갈) 릴리스를 적고, 그 버전에서도 생기면 다시 열어 달라고 써 주세요. #523처럼요.
    • 이럴 때는 저한테 넘겨 주세요: 제보자 파일로 재현을 못 해서 고쳐졌는지 확실하지 않을 때, 그리고 지원하지 않기로 하거나 중복으로 닫는 것처럼 판단이 필요한 경우요.

@SeoJCalive
SeoJCalive deleted the test/667-apply-look-path branch October 28, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants