Repository navigation
test(setup): check a language switch through ApplyLook shows the new texts (#667) - #723
Merged
Merged
Conversation
…texts Follow-up to #667 / #692. Through the real App.ApplyLook, SetLanguage("ko") changes both the app resource and a bound TextBlock in a shown window, and the switch raises at most 10 resource changes: one for the texts plus the fixed font and flow-direction changes, none of which grows with the number of keys. One write per key fails it with over a thousand.
Collaborator
Author
|
@KnifeLemon #667에서 말씀하신 이슈 닫는 것에 대해 하나 여쭤볼게요.
이슈 정리에 대한 개인적인 의견이라 편하신 방식 알려 주시면 그대로 할게요. |
KnifeLemon
approved these changes
Oct 28, 2026
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thanks, @SeoJCalive! Going through the real ApplyLook with a bound TextBlock checks what a user actually sees, and the 1–10 range keeps it from breaking when one more fixed resource is added. Putting English back in finally is right, since the test app is shared. I'll merge once the Windows build is green.
Owner
|
@SeoJCalive 머지하면서 질문을 놓쳤네요, 늦게 답해서 미안해요. 둘 다 직접 닫으셔도 돼요.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Follow-up to #667 / #692, as agreed in #667 (comment). Test only, no code change.
A_language_switch_through_apply_look_shows_the_new_texts(SetupTextsTests,[AvaloniaFact]) goes through the realApp.ApplyLook: afterSetLanguage("ko"), both the app resourceinstaller.installand aTextBlockbound to it in a shown window show the Korean text, and the switch raises at most 10 resource changes.The bound is a range (1 to 10), not an exact 4, as you suggested: the texts are one change, and the font (1) and flow direction (2) changes don't grow with the number of keys. With one write per key the count is over a thousand. The test starts from English and puts English back in
finally, since the test assembly shares one app.Type of change
Tests only.
How was it tested?
dotnet format --verify-no-changesdotnet test:SetupTextsTests61 passed, 1 skipped. ForcingPublishback to one write per key fails the new test with 1231 changes.Full
Filee.Setup.Testson Linux (Release): 145 passed, 1 skipped, 52 failed. The same 52 tests fail by name on main on this PC (Windows-only installer, registry andkernel32.dlltests, andSetupWindowTestswidth checks); the Windows CIbuildjob covers them. The new test passes.Screenshots (UI changes)
No UI change.
Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (none)THIRD-PARTY-NOTICES.md(none)