Repository navigation
fix(engines): find LibreOffice where its Windows installer recorded it - #719
Merged
Merged
Conversation
On Windows, LibreOffice was found only on the PATH and in Program Files, so a copy installed on another drive or in a folder of its own had to be picked by hand (Use my copy…). Its installer records the program folder as the default value of SOFTWARE\LibreOffice\UNO\InstallPath; that key is now read for this user and for all users, in the 64-bit and 32-bit views, after the PATH and before the Program Files guess. Refs discussion #671 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
On Windows, Filee found an installed LibreOffice only on the PATH and in
Program Files\LibreOffice\program. A copy installed on another drive (D:\LibreOffice) or in a folder of its own had to be picked by hand with Use my copy….LibreOffice's installer records its program folder as the default value of
SOFTWARE\LibreOffice\UNO\InstallPath. Filee now reads that key, for this user and for all users, in the 64-bit and 32-bit views, after the PATH and before the Program Files guess. A missing key or one Filee can't read is skipped.Raised in discussion #671.
Type of change
How was it tested?
dotnet format --verify-no-changeson the changed filesdotnet testforSystemCopyTestsandOwnCopyTests(Windows): the new test writes the key underHKCU\Software\FileeTests, with the path in quotes as installers sometimes write it, and checks that the folder is read back and holdssoffice.exe; a missing key gives nothing. The key is removed afterwards.Checklist
🤖 Generated with Claude Code