Repository navigation
Improve error handling in post-cdash-status - #4
Conversation
|
@vicentebolea I'd forgotten about this. I think it's ready for final review. |
|
@hainest looks good, this might be out of the scope of this PR, it will be nice to add a unit test that checks the status of a a known commit in cdash project. Feel free to do it here or in a followup PR |
Is that possible to do? I thought the dashboard history is cleared periodically. |
we could inquire a recent commit of a project such a cmake. |
Sounds good. I'll make a separate PR for that. |
|
@vicentebolea It looks like I'm not allowed to merge. Could you do it for me? |
|
testing in master seems to have failed: https://github.com/Kitware/cdash-status/actions/runs/33543107154/job/99973956937#step:3:43 |
|
|
@vicentebolea It's failing because the status is associated with the HEAD of the PR (fb36010), but it's testing the HEAD of master which is 392e931. That test will only pass on pushes for single-commit PRs that aren't rebase-and-merge or squash-and-merge. |
Good catch. lets only allow merge commit merges to avoid this. |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This also adds authentication to the status query to match the rate-limit of the POST. I'm not sure if it's strictly necessary, but I found it useful when testing.