Align all general DebugUtilsMessengerCallbacks as in hpp_hello_triangle. - #1579
Open
asuessenbach wants to merge 1 commit into
Open
asuessenbach wants to merge 1 commit into
asuessenbach wants to merge 1 commit into
Conversation
asuessenbach
force-pushed
the
debug_callback
branch
from
September 15, 2026 11:59
e6497ea to
d990244
Compare
Collaborator
IMO we should leave it that way. Those samples are deliberately written to be as stand-alone as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As prepared with #1560, all general purpose debug callbacks are equalized with this PR.
One question, though: should the
*hello_triangle*samples really hold their own debug callback, or should we prefer to use one provided by the framework?Build tested on Win11 with VS2026. Run tested on Win11 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: