Conversation
asuessenbach
previously approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1565
vkAcquireNextImageKHRcan returnVK_SUBOPTIMAL_KHRafter acquiring a usable swapchain image and signaling the acquire semaphore. The affected samples treated every non-VK_SUCCESSresult as a failed acquisition and immediately returned the semaphore to the recycle pool. The still-signaled semaphore could then be reused by a later acquire operation, triggering a validation error.Treat
VK_SUBOPTIMAL_KHRas a successful acquisition for semaphore ownership purposes. This keeps the semaphore associated with the acquired frame instead of recycling it through the failure path. The Vulkan-Hpp 1.3 path also keeps the fence wait result separate from the acquire result and normalizes the handled acquisition to success.Affected samples:
hello_trianglehello_triangle_1_3hpp_hello_trianglehpp_hello_triangle_1_3full_screen_exclusiveTesting
vulkan_samplesDebug target successfully on Windows with MSVC/Visual Studio 2026.python scripts/copyright.py main.git diff --check main...HEAD.VK_SUBOPTIMAL_KHRreturn path could not be reproduced reliably on the available systems. The change follows the Vulkan acquire-result semantics and addresses the semaphore lifecycle reported in Validation error in hello_triangle: semaphore must not be currently signaled. #1565.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: