fix CI - #159
Open
bashbaug wants to merge 9 commits into
Open
Conversation
The runners already have new enough versions of cmake and ninja.
This is needed to work with newer versions of CMake.
This avoids an issue with the lld linker affecting the shared glew library, which the SDK does not use. It also speeds up builds.
The directory overrides were not adding anything and were causing problems for some projects, which expected the output directories to be defaults.
These tests are passing for me locally, but are failing in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes various issues preventing CI from passing on the latest GitHub runners:
Note, I also enabled CI on pushes to branches other than
main. I can revert this if desired, but it will mean that CI will only run when a PR is created.