Skip to content

fix CI - #159

Open
bashbaug wants to merge 9 commits into
KhronosGroup:mainfrom
bashbaug:fix-windows-ci
Open

fix CI#159
bashbaug wants to merge 9 commits into
KhronosGroup:mainfrom
bashbaug:fix-windows-ci

Conversation

@bashbaug

Copy link
Copy Markdown
Contributor

Fixes various issues preventing CI from passing on the latest GitHub runners:

  • Updates to Visual Studio 2026 instead of Visual Studio 2022.
  • Removes the explicit CMake install step and uses the (newer) default CMake and ninja instead.
  • Updates the version for several third-party dependencies (freetype, GLEW, glm). The older versions did not work with a newer CMake.
  • Removes the output directory overrides for several third-party dependencies that no longer work with the updated versions. Removes a few more output directory overrides that are not required, for consistency.
  • Only build the static GLEW library. The shared version was not building in CI, and the static version is the only version that is needed,
  • Disable the blur tests from Linux CI, since they are failing unexpectedly (issue filed: blur samples are failing in Linux CI #158).

Note, I also enabled CI on pushes to branches other than main. I can revert this if desired, but it will mean that CI will only run when a PR is created.

The runners already have new enough versions of cmake and ninja.
This is needed to work with newer versions of CMake.
This avoids an issue with the lld linker affecting the shared
glew library, which the SDK does not use.  It also speeds up builds.
The directory overrides were not adding anything and were causing
problems for some projects, which expected the output directories
to be defaults.
These tests are passing for me locally, but are failing in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant