Repository navigation
Enforce separate type-only imports - #1429
Merged
Merged
Conversation
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Owner
Author
|
Polish review: no P1/P2 findings.
Merge predecessor: none. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The documented separate type-import convention was not enforced, leaving the final requirement of #1342 unfinished. Enforce it across the linted TypeScript files and convert existing imports to separate
import typestatements.consistent-type-importsfixes implicit type imports, while a syntax restriction rejects existing inlinetypespecifiers. Type-query annotations remain allowed. The supporting UI checksum pins are refreshed for import-only edits; component behavior and public contracts are unchanged.Closes #1342.
Closes #1338. Its recurring hotspots retain the accepted apply-when-touched disposition recorded in the issue.
Merge predecessor: none.
Validation
gate:allchecks pass: 4,665 application tests, 2,593 server coverage tests, 56 account-flow tests, three credential-durability tests and three migration rehearsal tests. The gate was resumed fromui:checkafter correcting file-size failures and refreshing reviewed primitive hashes; earlier passing structural checks were retained.pnpm run e2e: 290 passed.Checklist