Repository navigation
Name the tenant boundary account in code - #1426
Merged
Merged
Conversation
Rename tenantStore, tenantIntegrity and tenantIndexes (and their tests) to accountStore, accountIntegrity and accountIndexes, and rename their exported Tenant/TENANT identifiers to account equivalents. SQL text, trigger and index names, migration names and error messages are unchanged, so released migration checksums still match. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Rename app.orgs.test.ts to app.companyCreation.test.ts and say company instead of org in its test titles. The POST /api/orgs route keeps its URL. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Move the code, UI and wire naming table to conventions.md as one table covering account, company, accountId, workspaceId, resource, member, principal, user, provider account and session. The development guide's section now points to it, and its storage paths follow the renamed modules. Add a user-facing glossary entry for resource. Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
…ulary # Conflicts: # server/src/accountIndexes.ts
This was referenced Oct 1, 2026
Owner
Author
|
Polish review: no P1/P2 findings.
Merge order for this batch: #1411, #1412, #1414 → #1413, #1415, #1416 → #1417 → #1418, #1419 → #1420 → #1421 → #1422 → #1423 → #1424 → #1425 → #1426. Predecessor: #1425. |
…ulary # Conflicts: # docs/reference/conventions.html # docs/reference/development.html # docs/reference/glossary.html
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1409 (T14). Merge predecessor: #1425 (this PR's base branch,
feature/comment-voice-sweep).account, the interface says "company", the wire saysaccountId.docs-src/reference/conventions.mdholds the vocabulary table: account, company,accountId, theworkspaceIdaccount-port alias, resource, member, principal, the Better Authuserrow, provider account and session. The section indevelopment.mdnow points to it.tenantStore.ts,tenantIntegrity.tsandtenantIndexes.tsbecomeaccountStore.ts,accountIntegrity.tsandaccountIndexes.ts, with their tests and exported names. SQL text, trigger and index names, migration names and error messages are byte-identical; the migration checksum pins pass unchanged.app.orgs.test.tsbecomesapp.companyCreation.test.ts; the/api/orgsroute is unchanged.development.mdand the privacy stories cite the new paths.No wire, route, schema or migration change.
Validation: Integrated Batch 4 tip (all five Batch 4 branches):
pnpm run gate:allandpnpm run e2e(290 passed) on Node 24.16.0. Later changes on the stack touch only comments, the comment checker and two reference pages; on the final tip typecheck, lint, format, the comment-voice check and its test,ui:check,docs:buildandpnpm run gate:serverpass. Independently reviewed; findings applied. Migration checksum pins pass unchanged.Merge order
Merge predecessor for this PR: #1425.