Repository navigation
Migrate NetworkManager proxies to zbus 6 - #29
Open
cfilipescu wants to merge 2 commits into
Open
cfilipescu wants to merge 2 commits into
cfilipescu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the normal and development zbus dependencies to 6.1.0 so applications using zbus 6 can pass their connections and values to the NetworkManager proxies.
?from proxy builder.path(...)calls; zbus 6 reports errors atbuild().await.zbus::zvarianttype paths in compiled code and examples with their zbus 6 equivalents, keeping the existing Clippy-D warningscheck passing.Consumers must also use zbus 6 for types passed to these proxies. Generated blocking proxies are removed by zbus 6.
Validation on Rust 1.89:
cargo check --all-targets --all-features --lockedcargo test --all --all-features --lockedcargo clippy --all --all-targets --all-features --locked -- -D warningscargo fmt -- --checkA downstream
wifi-portalsmoke build in a temporary copy ofEPIC-BLOCKCHAIN/boot-utils, using zbus 6.1.0 and this checkout, also passes with deprecated-import warnings in the consumer. Real NetworkManager/hardware behavior has not been tested.