Merge v17 into v18 (2026-09-12) - #1086
Merged
Merged
Conversation
Adds AdditionalBadNames and IncludeWindowsReservedNames to uSyncSettings so the export-time unsafe-filename check (app.config/web.config) can be extended via appsettings.json, optionally including Windows reserved device names (CON, COM1-9, LPT1-9, etc). Built-in defaults stay active either way. ToAppSafeFileName gets an additive overload taking the extra names so existing callers are unaffected. The merged list is cached per handler instance to avoid rebuilding it per exported node.
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-ports the v17 work landed after the last forward merge (#1081)
that was still outstanding.
#1085: adds
AdditionalBadNames/IncludeWindowsReservedNamestouSyncSettingssothe export-time unsafe-filename check can be extended via
appsettings.json, optionally including Windows reserved device names.ToAppSafeFileNamegets an additive overload taking the extra names.Applied cleanly on top of the
ToAppSafeFileNamefix already ported inMerge v17 into v18 (2026-09-08) #1081.
Not ported (judgement call, left for a separate decision):
build workflow to manual prerelease trigger" — renames v17's
package-build.ymltoprerelease.ymland switches its trigger toworkflow_dispatch. v18'spackage-build.ymlis still push-triggeredbut was already independently modernized past v17's CI in Merge v17 into v18 (2026-09-08) #1081, so
this is being held back rather than ported automatically.
Test plan
dotnet build ./uSync.slnx -c Release— succeeds, 0 errorsdotnet test ./uSync.Tests/uSync.Tests.csproj -c Release— 230/230 passedPlease merge with a merge commit, not squash, so the next forward-port
run can find this baseline directly from ancestry.
🤖 Generated with Claude Code