Skip to content

[R5] Handle optional billing rejections and investigate Android startup - #7158

Closed
antuz123 wants to merge 439 commits into
sprintfrom
codex/r5-android-skip-target-20261024
Closed

antuz123 wants to merge 439 commits into
sprintfrom
codex/r5-android-skip-target-20261024

Conversation

@antuz123

@antuz123 antuz123 commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

State: CLOSED_SUPERSEDED_NOT_ACCEPTED

Superseded by #7164, published source a23d9a9c92cb4cdddca03e07844a722805f74f24. This draft's complete source history is incorporated in that candidate.

This administrative closure grants no native, physical, security, combined R5 or release acceptance. All prior failures, NOT RUN items, handoffs, source-specific evidence and physical-scope decisions below remain unchanged. Continue work in #7164.


The app discarded the promises returned by optional billing initialization and cleanup. A rejected native binding/init/cleanup call could therefore become an unhandled rejection. This change owns both promises while preserving the pinned IAP adapter's existing error logging, native invocation order and cleanup behavior.

A regression executes the actual App effect and pinned adapter against disposable native boundaries. It covers missing binding, initialization rejection, cleanup rejection and success; an independent late-rejection control also runs after cleanup. The regression is selected by the existing early CI Node command after frozen dependency installation and patch application, before later Jest/Realm checks.

Exact head: 436bf76; tree 288811a6c36c0823253780f4141fe74928753f29. Three-path delta against0facc9045ef258a8706964ef03376e8d3e5c626b: App.tsx, tests/services/appBillingLifecycle.test.cjs, and .github/workflows/test.yml. No dependency, native binding, navigation, storage, UI wait/assertion, product threshold, credential or canonical authority change. Independent all-path exact-source and root reviews cleared this scope. Focused actual-adapter regressions and workflow lint pass. Inherited App lint findings remain; shellcheck/pyflakes and local Ruby are unavailable. A peer's broader existing CI-command attempt retained its environment-blocked iOS guard failures; no combined local CI pass is claimed.

The current Android first-screen failure is unresolved. The previous exact0facc run https://github.com/KeeperCommunity/bitcoin-keeper/actions/runs/40111205437 (attempt1) built successfully but failed the Create-passcode assertion before Skip instrumentation ran. The same billing fault also appeared in earlier9ffe when startup/persistence/worker probes passed, so it is not established as the cause of the later startup or first-wallet failures. Earlier exact9ffe run40105347015 reached product Skip but failed StartNew. These failures remain preserved; no pass transfers across sources.

Native opt-in was removed before this fast-forward. This update selects ordinary CI only; no new Android native run is authorized here. No source promotion, release signing, upload, distribution or deployment occurred.

Codex local handoff

State: NEEDS_LOCAL
PR: #7158
Base: sprint
Head branch: codex/r5-android-skip-target-20261024
Head commit: 436bf76
Goal and acceptance criteria: preserve optional billing failures without unhandled rejections, resolve the Android first-screen/first-wallet blocker, and complete exact-source native acceptance.
Changes made: scoped billing promise ownership and CI regression selection on the existing Android diagnostic candidate.
Cloud checks: focused actual-source billing regression and independent/root source review PASS; current-head native NOT RUN; previous-head startup failures preserved. Ordinary CI pending after source update.
Required local checks: IOS, ANDROID, HARDWARE
Local checks requested: cross-platform native checks on the eventual integrated source, first-screen/first-wallet Android acceptance, and separately scoped physical phone/signer checks. No personal Mac is required.
Risks / known gaps: Android startup cause and missing native binding remain unresolved; no current-head native or combined R5 acceptance. No release operation authorized by this source change.

redkeep-agents and others added 30 commits October 13, 2026 03:54

antuz123 commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator Author

Coordinator-selected parallel Android-only diagnostic — 24 October 2026, 10:24 UTC.

Freeze 3f4e8127e3698accd3760a4a039448964a5285a4, tree e2f514a121b2cc41c4e2d2ba8bb3825d990608c7. Root393Python/29Node/two-actionlint checks PASS; independent29Node/50Python/two-actionlint review CLEAR. Production app/native/dependency/shared-worker/full-flow input fences remain unchanged against7c; only the Android same-button Skip command and diagnostic selection change. This is a hypothesis, not an established app fix.

The owner explicitly authorized parallel independent work. Fresh complete active-run snapshot shows only the existing frozen iOS-only40084560886/7c native app window. Its job120844708599 is building; Android is not selected there. This PR's legacy hosted iOS/Android jobs are terminal SKIPPED; no active Android app job is reported. Queued work is the draft release-provenance workflow, not a selected native app job. Live7158 is draft at the exact reviewed head with only keeper/android-diagnostic-only.

Add keeper/native-diagnostic once. This selects one Android-only Linux job here while the separate7c iOS-only macOS job continues uninterrupted. Both workflows use distinct PR concurrency groups with cancellation disabled. No duplicate platform build, cancellation, shared-source advance, physical result, acceptance waiver or cross-head pass combination is authorized.

The single intended Android Skip command targets the source label within the same button; destination, deadlines, metrics, backend counts and all other product requirements remain. Report the actual runtime result and preserve failures. Keep source frozen through terminal execution. R4/1d8, integration8b56 and private proposals remain separate. No installed trust, merge, release signing, upload/distribution or deployment authority.

Actual execution progress

Terminal FAILURE: 40085793409/a1, Android job120848340201, exact frozen3f4e8127e3698accd3760a4a039448964a5285a4. Checkout/source guard, immutable dependencies and development build PASS. Startup smoke failed waiting for Create a passcode. Native persistence, worker and product phases did NOT RUN. The Skip-label experiment was NOT EXERCISED and remains unvalidated; it was not disproved by this earlier failure.

Safe startup observations: one Metro error header and five unclassified context lines, no recognized fault category; app process PRESENT/foreground OWN_APP; no PIN hierarchy signal or owned runtime fault. Cause remains UNDETERMINED. Retained artifact12557603923 is6451bytes, original ZIP SHA256f3553f9632eff7bd25f2315c8fb0e5429132455ea0af7d5293d4e4c7cfd8fd40; workflowf83a9a8b182dd8276a732ee2b6338fb6f845640a/refs/pull/7158/merge. Evidence retention PASS; iOS and driver-preflight actually SKIPPED. No new native run, source advance, retry, cancellation, cross-source acceptance or release operation.

@antuz123 antuz123 changed the title test(ci): target the Android Skip label in an isolated diagnostic ci: diagnose Android startup with standard logs and source coordinates Oct 24, 2026

Copy link
Copy Markdown
Collaborator Author

Frozen Android diagnostic selection

Select exactly one Android-only diagnostic on head 9ffe2f417b31440c738e48c1d8eecdae2a0b9e28, tree 85802003f6a128543fbe28a9323c189e73a3d4b3. Root exact-source review is CLEAR; root399Python/21Node controls PASS, independent review CLEAR, source and production/dependency/workflow/UI-flow fences PASS.

Native opt-in was removed and verified absent before the existing branch was fast-forwarded from frozen3f4; no force push or new PR. The opt-in-free synchronize run40105254939 actually SKIPPED iOS, Android and driver-preflight. Current draft/head/Android-only modifier were rechecked; no iOS-only conflict exists.

Fresh repository in-progress and queued snapshots plus native-job inspection found no competing Android native job. The separately owned iOS dependency investigation 40104929679, exact64ae7b53ac8a363a20287afc135ea33eeb428510, stays separate on its own hosted VM/concurrency group.

The coordinator now adds keeper/native-diagnostic once. Only Android is selected. Report build, startup, persistence, worker and product phases as their actual separate results; retrieve existing artifacts directly and strictly regenerate typed identities/public source coordinates. No new metadata-reader workflow is needed.

Source is frozen until terminal. Prior3f4 failure/readout and all other heads remain unchanged; no cross-head pass, installed-trust/native/full acceptance, retry, cancellation, source advance, shared merge, signing, upload, distribution or deployment authority. Underlying app startup cause remains UNKNOWN until actual evidence establishes it.

antuz123 commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator Author

Android cloud diagnostic — terminal result on9ffe

Head: 9ffe2f417b31440c738e48c1d8eecdae2a0b9e28; tree 85802003f6a128543fbe28a9323c189e73a3d4b3.
Run40105347015/attempt1, Android job120905779655: overall FAILURE.

Recorded phase Actual result
Exact checkout/source guard, toolchain and immutable dependencies PASS
Development build PASS
First-screen startup and disposable PIN-input smoke PASS
Native persistence probe PASS
Scoped production-worker native scenarios PASS
Full-product samples FAIL on sample1; samples2–5 NOT RUN
Retry and later UI companions NOT RUN
iOS / driver preflight SKIPPED
Physical devices and release operations NOT RUN

The first product sample reached startup_ready and nine host PIN/onboarding acknowledgements through skip_tapped, then failed ASSERT_VISIBLE start_new_tile at sequence37; backend createNewApp calls0. The inherited Android Skip-selector experiment was exercised and did not satisfy its destination assertion.

The bound post-assert Skip node is enabled/clickable at bounds[0,78]–[1038,134]. Actual tap coordinates, tap-time visibility and responder delivery were NOT RECORDED. One owned ONBOARDING_EFFECT marker was observed; press/reset/new-keeper markers are null under a positive-only collector, so their absence cannot be inferred. No product Metro error or current-owned runtime fault was recorded. The product cause remains UNDETERMINED.

The corrected startup telemetry retained29 valid uncapped Metro rows. It recorded IAP_INITIALIZATION_FAILED/NITRO_BINDING_MISSING plus an actual symbolicated public frame at App.tsx:32:19. This identifies the startup IAP initialization call, but startup/persistence/workers passed; it does not prove the later product failure's cause.

Artifact12565009997:10,021bytes, ZIP SHA256 1d3eae7e50d4fc86069b12440190b615bd89f2a616ed252d4fa3f9d368a6dc4d; metadata SHA256 ba6ba81a53b13ff1db2b7751166fa2777bdbe3eb22c98ce0739c80f6bb135a5e. Direct download, canonical ZIP checks, exact official source/workflow/job/attempt/artifact admission before+after decoding and strict typed/public-value regeneration PASS. Downloaded raw ZIPs were purged. No extra reader workflow was run.

Independent source audits executed the actual Skip closure, registered StackRouter and pinned TouchableOpacity/Pressability with synthetic input; valid delivery resets to NewKeeperApp. Pinned Maestro source confirms childOf can select its parent and command completion does not prove app onPress delivery. No causal RED→GREEN reproduction justifies a retry/delay/point change. No further native run or source change was made.

These outcomes belong only to9ffe. Prior3f4 failure, R4 source, R5 integration8b56 and private proposals remain separate. No cross-head/native/full acceptance, merge, release signing, upload, distribution or deployment approval.

@antuz123 antuz123 changed the title ci: diagnose Android startup with standard logs and source coordinates ci: retain Android Skip intent and owned press stages Oct 24, 2026

Copy link
Copy Markdown
Collaborator Author

Selecting one Android-only diagnostic on exact 0facc9045ef258a8706964ef03376e8d3e5c626b (tree e3d79448c796fc688ba0d8de8b48e56de9be8697, sole parent9ffe), following independent all-path CLEAR. Author410Python/32Node PASS; independent410Python/32Node plus88 boundary controls PASS; zero Node skips. Baseline source replay6PASS/5expected measurement failures establishes coverage only, not a causal app fix. All2,470 committed inputs match raw bytes/modes;2,460 outside the ten changed paths match9ffe;21 exact upstream source identities checked.

One-run question: Which initial owned Skip node and later intended driver point does the existing Maestro action record, and which owned press/reset stages emit? The flow/tap/selector/deadlines/navigation/responder policy are unchanged. Initial bounds are not refreshed bounds; intent is not Android delivery; missing records remain UNKNOWN. The collector exports no PIN/unrelated coordinates, UI/event payload or raw logs. Original failure and purge remain intact.

Native opt-in was removed and verified absent before the normal fast-forward. Opt-in-free synchronize 40111122714 has actual iOS, Android and driver-preflight jobs SKIPPED. Current-head release-acceptance iOS/Android jobs are also SKIPPED. Fresh active/queued checks found no competing Android native job; separate owned iOSb4 diagnostics remain independent. One native opt-in addition will select this Android run. No identical-source retry, further source advance or extra native run is authorized by this selection. No trusted/full acceptance, merge, signing or distribution authority.

antuz123 commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator Author

Terminal frozen-source execution: 40111205437/attempt1, exact 0facc9045ef258a8706964ef03376e8d3e5c626b, Android job120923122587, overall FAILURE.

Phase Actual retained outcome
Exact-source/toolchain/immutable dependencies PASS
Android development build PASS
Install/exact installed artifact VERIFIED
Startup/disposable PIN smoke FAIL — Create a passcode assertion
Native persistence and scoped workers NOT RUN
Full-product samples/Skip measurement/Retry/companions NOT RUN — startup blocked them
iOS / driver-preflight SKIPPED
Hardware / release signing NOT RUN

The Maestro report is PRESENT with testcase ERROR and fixed failure Maestro assertion failed: Create a passcode. One retained legacy hierarchy snapshot has no Create/Confirm PIN, RN redbox or fixed script/server-error marker; no parse error. The reviewed Skip target/press-stage measurement was NOT EXERCISED. No causal app fix has been established.

Startup telemetry contains29 valid Metro rows, no truncation/invalid rows/cap hit. It records NATIVE_EVENT_EMITTER_NULL, IAP_INITIALIZATION_FAILED / NITRO_BINDING_MISSING, and an actual public symbolication frame App.tsx:32:19. The same IAP fault occurred during passing9ffe startup, so it is not established as this failure's cause or as proof of which native component is absent.

Direct artifact12567209711 (keeper-diagnostic-native-ANDROID-0facc9045ef258a8706964ef03376e8d3e5c626b-40111205437-1),6855bytes, official ZIP SHA256e9721aee623061b42b1ea7a295fd69769e06301169f8be6aa155548ad23c5a4e; metadata SHA256adbcf7a24c6e50a9081e947f0932745f028de2617523410af5171f1104fcf383; strict projected readout SHA256813b24c9736e1a213c265a8bdb9e3f73fee8b2e3be41de4dce7cf15bf4356c04. Fresh official run/head/attempt/workflow/job/artifact association checked before and after decode; exact artifact upload is confirmed by completed selected-job logs. The job-step API remained stale (build in_progress/retention pending despite terminal failure and uploaded artifact); that inconsistency is retained, with no pass inferred from those step fields. Actual phase outcomes above come from the source-bound reviewed metadata. Raw ZIP copies were purged; no new cloud-reader workflow was used.

Source remains frozen/clean. The single extra Android allowance is consumed. No retry, cancellation, further source/native selection, merge, signing or distribution was performed. The R5 first-screen and later Skip/product acceptance remain open; trusted/full release acceptance is not supplied by this diagnostic.

@antuz123 antuz123 changed the title ci: retain Android Skip intent and owned press stages [R5] Handle optional billing rejections and investigate Android startup Oct 25, 2026
@antuz123 antuz123 closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants