Skip to content

Document conditional cloud review and optional human review - #7034

Draft
antuz123 wants to merge 6 commits into
sprintfrom
codex/copilot-review-process
Draft

antuz123 wants to merge 6 commits into
sprintfrom
codex/copilot-review-process

Conversation

@antuz123

@antuz123 antuz123 commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Cloud review now depends on actual severity, uncertainty, scope and cost; human developer review stays optional. Verified routine documentation, noncritical copy or pure style may skip a separate provider review with reason/evidence, but policy/security/agent/workflow documents cannot Skip. Bounded normal changes use Lite; signing, keys, authentication, recovery/backup, pairing, transactions, migrations, workflows, permissions, security dependencies/copy, cross-service/complex changes and unknown risk use Balanced.

Use the least-cost adequate authorized route, reuse valid exact-head/base coverage, make one initial review after stable checks and batch material fixes before necessary re-review. Independent coverage is needed only when an actual risk/finding requires it and an installed, authorized route/scope/budget exists. If scope, quota, cap or activation is unavailable, record unavailable and use another already-authorized adequate route or hold the applicable gate. Do not downgrade critical review, add paid retries/fallbacks or infer fresh allowance. Existing caps and historical balances do not activate a reviewer or grant budget; ordinary within-scope/allowance review does not need repeated permission.

Actual findings/dispositions, reviewed SHA/base/coverage and skipped/pending/unavailable results must be recorded. Required CI/status checks, substantive security concerns, native/device validation, product signoff and operation-specific signing/deployment/release authorization remain intact. Existing comment-only human CODEOWNERS suggestions remain optional and require no access grants.

Policy/docs/templates/agent instructions only: no runtime, workflow, R5 implementation, permission, secret, budget, merge or deployment change. No new provider request or paid review is claimed. Current recorded Copilot ready-PR automation, plus mobile every-push review, does not implement conditional triage; Markdown does not fix settings or install mobile reviewer #7049. Keep source preparation and installed automation status separate.

Historical receipts remain tied to exact original commits. Record current-head validation separately; skipped/unavailable review is not a clean review.

Preserve contributor #7030's unified lowercase template, contributor test/security sections and any required add/add reconciliation.

Current conditional-policy head: 54f6d420202fe7fdbfa280c11196d850b032f731. An existing cloud agent who did not author these policy edits independently reviewed the exact prepared patch (manifest SHA-256 a0bf37b7be612932af8911e329899178f7db123c6b66aa0cd2a492df108b6a5a); no blocking finding. This is cloud-agent source evidence, not a completed Copilot/Claude provider review or formal GitHub approval. Fresh exact-head CI evidence follows. Policies remain draft/unmerged and live GitHub rules are unchanged: administrator access is still needed to remove enforced human approval and implement conditional triggering. No ready transition or new provider/paid review was requested.

Fresh exact-head CI: Fresh exact-head CI39733626667 passed all183 tests across17 suites. CodeQL39733626420 and aggregate checks passed. keeper/local-validation passed through the documented docs/GitHub metadata-only exemption; no native/device test is claimed. Lint job conclusion is success under existing nonblocking configuration, but the lint command exited1 with5453problems(4540errors,913warnings); no clean-lint claim or new suppression.

Copy link
Copy Markdown
Collaborator Author

R4 review-policy integration continuation — 12 October 2026

Current source head: 2b55b6e9c5630628bacacc43191616d7f5b03797.

Merged current sprint 53f0ddd01e594c63e3c8d38824a6c2fc2e05c101 into this policy branch and deliberately reconciled the add/add AGENTS.md conflict. The result keeps the full Cloud → Local handoff, exact-head validation and release-approval contract, then adds the independent developer/product review requirements. No app source is imported or modified by this refresh.

The review policy now states the intended Copilot configuration without claiming a Markdown proposal changes GitHub settings. Native exact-head validation, independent human approval, product signoff and retrospective owner acceptance are separate gates. The unified lowercase template retains contributor test evidence/security considerations and an explicit link to product-owner decisions.

Validation: Markdown links, newlines and conflict-marker checks passed; both handoff/validation formats and exact-SHA/independent/product requirements were asserted; the inherited validation workflow YAML parses; git diff --check passed. No native tests are necessary because this PR changes only documentation and .github/ files.

Live read-only settings audit: active Keeper PR Validation ruleset already requires keeper/local-validation and Tests for sprint. Its human approval count is 0; a legacy branch-protection read is blocked HTTP 403, so overall human enforcement remains unverified. The operational one-independent-developer requirement remains. The active Copilot sprint ruleset still has every-push review enabled and draft review disabled; settings do not yet fully match this policy. No settings, reviewer permissions or spending were changed.

Keep draft with independent approval pending. Intended effort: Lite for documentation/process; no completed Copilot review is claimed. #7030 and this PR both add .github/pull_request_template.md; integrate the unified policy template deliberately after #7030, preserving its contributor sections. Policy source is a separate deliverable from #7045's app assembly and does not authorize merge, signing, deployment or release.

Copy link
Copy Markdown
Collaborator Author

Current-head CI boundary

Policy source 2b55b6e9c5630628bacacc43191616d7f5b03797 is conflict-free. CodeQL and the docs-only local gate passed, but Tests 38212049185 failed 1/183 in the inherited wrong-key AES UTF-8 assertion (182 passed). The combined R4 app/source CI branches carry a test-only correction; this policy PR preserves its documentation/.github-only scope. Review can assess the policy with that baseline failure disclosed; its own Tests gate remains red until the approved baseline dependency is reconciled. Lint job success is informational, not clean lint. No merge/settings/reviewer/billing change or native result is claimed.

Copy link
Copy Markdown
Collaborator Author

Policy CI verification retry

On unchanged source 2b55b6e9c5630628bacacc43191616d7f5b03797, the single failed-job verification retry CI 38212049185 attempt 2 passed 17/17 suites, 183/183 tests. The initial wrong-key UTF-8 assertion failure and inherited nondeterminism remain disclosed; a retry is evidence of this run, not a source fix. No further retry or test/runtime import was made, preserving policy-only scope. Independent policy approval, intended settings/access and baseline integration remain separate gates. No merge, source permission/settings or spending change occurred.

@antuz123 antuz123 changed the title Document Copilot effort and developer review process Document Copilot effort and optional human review Oct 22, 2026
@antuz123 antuz123 changed the title Document Copilot effort and optional human review Document conditional cloud review and optional human review Oct 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants