Skip to content

Deferred: stabilize passcode keypad labels and touch targets (#6932) - #7025

Draft
antuz123 wants to merge 3 commits into
release/2.6.3from
codex/r3-passcode-keypad
Draft

antuz123 wants to merge 3 commits into
release/2.6.3from
codex/r3-passcode-keypad

Conversation

@antuz123

@antuz123 antuz123 commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Change

  • Render keypad digits with native Text, retaining existing size/color and accessible digit labels.
  • Remove the redundant gesture wrapper where the authentication keypad already provides press feedback.
  • Keep keypad containers and rows as non-collapsible native Views, preserving the existing row height, bottom alignment, themes, decimal mode and disabled state.

Verification

  • Reproduced Passcode keypad shows missing digit randomly. #6932 on the current signed arm64 iOS 2.6.3/619 Debug simulator: after login reload, digit 1 and its entire accessible target were absent. Other digits were present.
  • A/B native checks: old Gluestack rows fail repeatedly (key_1=0); native rows pass repeated reloads (all ten targets present); restoring old rows fails again; restoring the fix passes.
  • All ten digits tapped and cleared on an isolated iPhone 13 mini / iOS 26.4 simulator. Passcode creation and login succeeded with disposable TESTNET data. This is simulator evidence; the affected physical iPhone will be checked retrospectively by the owner after release.
  • Focused keypad/PIN tests: 7/7 pass, including all digit callbacks, rapid entry, confirmation and decimal/delete behavior. Prettier/diff checks pass.
  • Latest PR test workflow passes. The legacy release branch SonarCloud Scan fails; it is an external, nonrequired check in this workflow.

Delivery

One developer approval is required; product signoff is separate. Ben, Utkarsh and Parsh are requested reviewers. Exactly one normal Copilot review request was made after readiness. Copilot reports the requester reached quota, so no code review was performed; it was not retried. The remaining developer approval is independent of AI review.

This PR currently targets the historical release/2.6.3 baseline. Shared baseline #7031 must land before retargeting to sprint, keeping unrelated baseline commits out of this fix. No merge or app release is claimed here.

Owner deferral — 8 October 2026

The owner reports that the live iOS digit is briefly invisible and has explicitly chosen to ignore/park this for Later. Preserve the existing implementation and evidence, stop further keypad work, and remove this PR from current R3 delivery gates. It is not scheduled for R4 or a particular app version. Do not merge/restart/review this work automatically; return to it only when the owner selects it again.

The current App Store 2.6.3/619 build does not contain this patch. This deferral is not a claim that the live symptom or the original #6932 report is fixed.

@antuz123
antuz123 marked this pull request as ready for review October 7, 2026 13:47
@antuz123
antuz123 requested a balanced review from Copilot October 7, 2026 13:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@antuz123 antuz123 changed the title fix: stabilize passcode keypad labels and touch targets (#6932) Deferred: stabilize passcode keypad labels and touch targets (#6932) Oct 8, 2026
@antuz123
antuz123 marked this pull request as draft October 8, 2026 10:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants