added support for enterprise node, role and user commands on JS SDK - #221
Open
sgaddala-ks wants to merge 1 commit into
Open
added support for enterprise node, role and user commands on JS SDK#221sgaddala-ks wants to merge 1 commit into
sgaddala-ks wants to merge 1 commit into
Conversation
sgaddala-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
July 29, 2026 15:25
tylerccarson
reviewed
Aug 3, 2026
| } | ||
| } | ||
| return null | ||
| } |
Contributor
There was a problem hiding this comment.
ECC should be preferred over RSA
tylerccarson
reviewed
Aug 3, 2026
| node_id: number | ||
| parent_id: number | ||
| encrypted_data: string | ||
| } |
Contributor
There was a problem hiding this comment.
There appears to be some code duplication here, node_add is already in commands.ts: https://github.com/Keeper-Security/keeper-sdk-javascript/blob/main/keeperapi/src/commands.ts#L214-L223
tylerccarson
reviewed
Aug 3, 2026
| node_id: number | ||
| parent_id: number | ||
| encrypted_data: string | ||
| } |
Contributor
There was a problem hiding this comment.
tylerccarson
reviewed
Aug 3, 2026
|
|
||
| type NodeDeleteRequest = { | ||
| node_id: number | ||
| } |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.