Repository navigation
fix(web): pulse today label text instead of clipped outline - #4468
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 507.7 KB gzip (+0.0 KB vs main) |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4465
What and why
Pressing
twhile already on today triggers a no-op cue on today's weekday label and the now line. The label used the same box-shadow ring as the now line, which the week header clips at the bottom. This change keeps the now-line ring animation and replaces the label cue with a brief text-only pulse (accent color and brightness on solid labels, brightness-only on the gradient day number) with no border, outline, or box-shadow and no layout shift. Day view uses the same label pulse on the SelectView heading.Verify
CI (required): unit, static, e2e, macos, boot-bundle — all pass on PR head (CodeQL swift ignored per task).
Local:
bun test:web675 pass; DayLabels and SelectView now-cue class tests added.VERDICT: PASS (CI required checks on PR #4468)