Repository navigation
fix(web): keep calendar grid aligned across US DST transitions - #4460
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1192
Fixes #1285
What and why
Week and day views treated every civil day as exactly 1440 minutes and 24 hour rows, so the now line, click-to-create positioning, scroll-to-now, and secondary timezone labels drifted on US fall-back (25-hour days) and spring-forward (23-hour days). Persisted timed events could also show stale offset strings after a transition. This change uses shared civil-day length helpers in core, renders 23/24/25 grid rows from the effective timezone, and re-anchors timed display instants to each event's schedule zone for grid rendering.
Verify
Checks run: test:core, test:web, type-check, lint, knip, test:a11y, test:e2e