Repository navigation
feat(analytics): instrument OAuth signup drop-off in PostHog - #4459
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4458
What and why
Google/Microsoft/Apple OAuth signup drop-off was hard to measure in PostHog because callback failures often never reached client-side
signup_failed, and server token exchange was invisible to the browser funnel. This change embeds the PostHog anon distinct id in OAuthstate, relays provider callback queries to backendGET /auth/:provider/callbackfor server captures, and adds aligned client events (oauth_callback_received,oauth_failed) while keeping legacyoauth_redirect_started,signup_failed, andsignup_completed/login_completed.Verify
VERDICT: PASS
Checks:
test:core,test:web,test:backend:fast,type-check,lint,knip,test:a11y,test:e2e(afterbunx playwright install chromium).