Repository navigation
Correction to "Forecast capping if calibrate forecast is too far from the uncalibrated" - #25
Merged
Conversation
…ons, so that these values can be used as bounds to clip the calibrated forecast.
Merged
3 tasks done
Kat-90
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/1281, metoppv#2449
Description
This PR tries to address some issues with metoppv#2449, with the main change being to ensure that we look across all percentiles and realizations to identify the min and max within the original forecast, rather than just using the first percentiles or realization, which could be e.g. the 5th percentile, which would be undesirable, as we wouldn't want to clip all the forecasts based on the 5th percentile.
Testing: