Skip to content

Fix CMake invocation for CMake version 3.10 - #65

Open
Single750 wants to merge 1 commit into
KarypisLab:masterfrom
Single750:fix_makefile
Open

Single750 wants to merge 1 commit into
KarypisLab:masterfrom
Single750:fix_makefile

Conversation

@Single750

Copy link
Copy Markdown

Description:
The Makefile uses -B "$(BUILDDIR)" which is only supported by CMake 3.13+.
The README states that CMake 3.10 is supported, so this is a bug.

Fix: remove the space between -B and the build directory path:

  • cmake "$(CURDIR)" -B "$(BUILDDIR)" $(CONFIG_FLAGS)
  • cmake "$(CURDIR)" -B"$(BUILDDIR)" $(CONFIG_FLAGS)

Tested on:

  • CMake 3.12.4 (works after fix, fails before)
  • CMake 4.2.3 (works both before and after)

…_dir>`, but it does support the combined notation `-B<build_dir>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant