fouine: update REVIEW.md from review feedback - #68
Closed
fouine-review[bot] wants to merge 1 commit into
Closed
Conversation
Author
|
Reviewed the diff — looks good. Verified all claims in the new
The file is 16 lines of accurate, actionable guidance. Nothing to cut. Blocking: 0 · Nits: 0 · Questions: 0 · mergeable once nothing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was learned
PR #66 — fouine correctly identified that the TypeScript 7 upgrade was incomplete: root was bumped to
^7.0.0but the 4 workspace packages (pbkit,pbkit-realtime,pbkit-tanstack,pbkit-zod) still had^6.0.0. The human confirmed and fixed. This validates the rule: always check all workspace packages for consistent dependency versions.PR #65 — Automated Changesets release PR, no findings, no actionable human feedback. Added a brief note about not over-scrutinizing mechanical changeset PRs.
No prior REVIEW.md existed; this is the initial version.
🦡 Proposed by fouine's outer-loop improver from human feedback on recent review threads. Merging updates the guidance injected into every future review; close to reject.