Skip to content

feat(sdk-generator): make OAuth2 redirectUrl optional (#63) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karnak19 merged 1 commit into from
Jul 8, 2026
Merged

feat(sdk-generator): make OAuth2 redirectUrl optional (#63) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/oauth2-redirect-optional.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@karnak19/pbkit": patch
---

Make `redirectUrl` optional in generated `auth*WithOAuth2` functions, matching PocketBase v0.39.4 which dropped the required `redirectURL` validator from `authWithOAuth2Code()`.
2 changes: 1 addition & 1 deletion packages/pbkit/src/sdk-generator/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function authFunctions(col: CollectionSchema): string[] {
lines.push("}");
lines.push("");
lines.push(
`export async function auth${s}WithOAuth2(provider: string, code: string, codeVerifier: string, redirectUrl: string, opts?: { client?: PbClient }): Promise<${p}Record> {`,
`export async function auth${s}WithOAuth2(provider: string, code: string, codeVerifier: string, redirectUrl = "", opts?: { client?: PbClient }): Promise<${p}Record> {`,
);
lines.push(" const pb = opts?.client ?? client");
lines.push(
Expand Down
2 changes: 1 addition & 1 deletion packages/pbkit/src/test/__snapshots__/sdk-generator.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export async function authUserWithPassword(usernameOrEmail: string, password: st
return result.record as unknown as UsersRecord
}

export async function authUserWithOAuth2(provider: string, code: string, codeVerifier: string, redirectUrl: string, opts?: { client?: PbClient }): Promise<UsersRecord> {
export async function authUserWithOAuth2(provider: string, code: string, codeVerifier: string, redirectUrl = "", opts?: { client?: PbClient }): Promise<UsersRecord> {
const pb = opts?.client ?? client
const result = await pb.collection("users").authWithOAuth2Code(provider, code, codeVerifier, redirectUrl)
return result.record as unknown as UsersRecord
Expand Down
Loading