Skip to content

Update README.md - #6

Merged
ReoTsukasa merged 3 commits into
mainfrom
fix_decoding_README
Sep 8, 2026
Merged

Update README.md#6
ReoTsukasa merged 3 commits into
mainfrom
fix_decoding_README

Conversation

@micchu

@micchu micchu commented Sep 8, 2026

Copy link
Copy Markdown
Member

I fixed the example execution command because it was missing the config/ directory path, which caused an obvious error.

I fixed the example execution command because it was missing the `config/` directory path, which caused an obvious error.
@micchu micchu self-assigned this Sep 8, 2026
@micchu
micchu requested review from ReoTsukasa and oopsyrah and a lite review from Copilot September 8, 2026 09:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated commands still reference a config filename that does not exist in feature-decoding/config/, so copy/paste usage will continue to fail.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the feature-decoding documentation to make the example commands runnable by correcting the relative path to the config YAMLs.

Changes:

  • Prefixes example config file arguments with config/ in the training and prediction commands.
File summaries
File Description
feature-decoding/README.md Fixes the example command arguments to reference configs via the config/ directory.
Review details

Suppressed comments (1)

feature-decoding/README.md:55

  • This example references a config file name that does not exist in feature-decoding/config/ (it appears to be missing the -image segments used by the actual config YAMLs). Updating to an existing config filename will prevent copy/paste failures.
python scripts/predict_feature_fastl2lir.py config/train-3d-natural-objects_rep3_fmap_test-3d-natural-objects_rep8_fmap_fmriprep_5000voxel_atlasnet.yaml
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread feature-decoding/README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The updated decode example points to a config filename that does not exist under feature-decoding/config/, so the copy/paste command will still fail.

Review details

Suppressed comments (1)

feature-decoding/README.md:56

  • The decode example references a config file name that doesn't exist in feature-decoding/config/ (it omits -image in both the training and test dataset segments). This will cause a file-not-found error when users copy/paste the command.
```bash
python scripts/predict_feature_fastl2lir.py config/train-3d-natural-objects_rep3_fmap_test-3d-natural-objects_rep8_fmap_fmriprep_5000voxel_atlasnet.yaml

- **Files reviewed:** 1/1 changed files
- **Comments generated:** 0 new
- **Review effort level:** Lite
</details>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation change is correct, matches the stated intent, and references an existing config file under feature-decoding/config/.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@ReoTsukasa ReoTsukasa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@ReoTsukasa
ReoTsukasa merged commit 7125e59 into main Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants