Repository navigation
feat(web): cohesive interface animations - #9
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interface state changes (labels, icons, overlays, the composer, counts) used to snap from one value to the next. This branch adds small, consistent motion to them, all following the existing UI animation duration setting, and turning off completely at 0 ms or with reduced motion.
What changed
AnimatedText), and swapped icons cross-fade (AnimatedIcon). Upstream'sMorphIconstill handles the copy/check icon swaps.@kitlangton/rolling-number(AnimatedNumber).createTimelineRowEntrance).The animation setting is published from the root into a small store in
uiAnimations.ts. The animation primitives used to readuseSettingsdirectly, which pulls in connection/session state. After rebasing on main, that created an import cycle (connection/platform → … → TraitsPicker → changing-state → useSettings → state/session) that crashed the app at startup.Evidence
Details panel with rolling Changes counts and the animated "Open in" label:
Opening and closing the inline details card:
Testing
vp test runon the touched tests (MessagesTimeline.logic, usage, ThreadDetailsPanel, ProjectScriptsControl, changing-state, ComposerPrimaryActions, uiAnimations, settingsSearch): passing.MessagesTimeline.test.tsxand 3 tests inChatCanvas.details.test.tsxfail onmaintoo; this branch doesn't touch those failures.Made with Claude Opus 5.5 in Claude Code (via T3 Code).