Repository navigation
feat(web): remember the last 3D or flat device view - #10
Merged
Merged
Conversation
Kaloyanes
marked this pull request as ready for review
October 28, 2026 14:48
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The device panel always opens in 3D. Choosing Flat view in the toolbar was only kept in component state, so every reload, new tab, or newly opened device went back to 3D. For anyone who finds the 3D view uncomfortable, that means switching to Flat again each time.
Change
deviceView("3d" | "flat", default"3d", so nothing changes for anyone who never touches it) inpackages/contracts/src/settings.ts.DeviceStreamViewreads it instead of its localuseState("phone"). The 3D view and Flat view toolbar buttons write it withupdateClientSettings, the same way the diff layout toggle does. The last choice is remembered across reloads and shared by all devices.docs/user/devices.mdmentions that the last choice is remembered. There is no settings row: the toolbar is the only control.Mobile has no 3D device view, so it is unaffected. This is a view preference, not an agent capability, so there is no MCP surface.
Scope and approval
Filed on my fork only (draft), not on
pingdotgg/t3code. It is a small preference on an existing control, not a new feature: no new UI, one contract field with a default.Verification
vp run check:changedpasses: format, lint, knip, typecheck (32 packages), and the 2 affected test files (theDesktopClientSettingsfixture now carriesdeviceView, so persistence of the new key is covered there).main'sDeviceStreamView.tsxtemporarily restored in the same worktree.Flat viewreportsaria-pressed=trueanddeviceView: "flat"is in the persisted client settings.Not checked: iPhone Duo and Android foldable 3D, the desktop (Electron) shell, and a remote or relay connection. There is no automated test for the toolbar toggle itself; I judged a browser test not worth the mocking for a one-line state swap.
Written by Claude Sonnet 5.5 (
claude-sonnet-5-5) in the Claude Code harness, run from T3 Code.