Skip to content

Run format check on pull_request instead of pull_request_target - #171

Merged
lkdvos merged 1 commit into
Jutho:masterfrom
leburgel:lb/format_check_pull_request
Sep 30, 2026
Merged

lkdvos merged 1 commit into
Jutho:masterfrom
leburgel:lb/format_check_pull_request

Conversation

@leburgel

Copy link
Copy Markdown
Contributor

The shared format check in QuantumKitHub/QuantumKitHubActions is now meant to be called from pull_request (QuantumKitHub/QuantumKitHubActions@e3f4c85). Called from pull_request_target, as here, actions/checkout refuses to check out the fork's code, so the check fails on every PR from a fork before Runic runs, e.g. #170:

Refusing to check out fork pull request code from a 'pull_request_target' workflow.

This switches the trigger to pull_request and drops the write permissions, matching TensorKit.jl and MPSKit.jl.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.65%. Comparing base (4808454) to head (cb70e2a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   88.47%   86.65%   -1.83%     
==========================================
  Files          36       36              
  Lines        3965     3918      -47     
==========================================
- Hits         3508     3395     -113     
- Misses        457      523      +66     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos merged commit 531b074 into Jutho:master Sep 30, 2026
10 of 14 checks passed
@leburgel
leburgel deleted the lb/format_check_pull_request branch September 30, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants