Skip to content

Use RealDot.realdot for more efficient real(dot(x, y))#355

Open
devmotion wants to merge 1 commit intomasterfrom
dw/realdot
Open

Use RealDot.realdot for more efficient real(dot(x, y))#355
devmotion wants to merge 1 commit intomasterfrom
dw/realdot

Conversation

@devmotion
Copy link
Copy Markdown
Member

This PR uses RealDot.realdot to perform computations of real(dot(x, y)) more efficiently. RealDot.jl is a very lightweight package that only defines realdot and only depends on LinearAlgebra: https://github.com/JuliaMath/RealDot.jl/blob/main/src/RealDot.jl

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (c4b0b83) to head (2d6a42f).
⚠️ Report is 166 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          12       12           
  Lines        2687     2687           
=======================================
  Hits         2506     2506           
  Misses        181      181           
Flag Coverage Δ
unittests 93.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj
Copy link
Copy Markdown
Member

I appreciate the thought here, but I'm skeptical that this can possibly matter much here given the cost of evaluating the Bessel functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants