Repository navigation
Use byte-range overlap for dense JLArray alias detection - #803
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #784, disjoint dense JLArrays sharing one allocation are reported as aliases, rejecting valid buffer-backed contractions in QuantumKitHub/TensorOperations.jl#310.
Specialize
Base.mightalias(::JLArray, ::JLArray)using half-open byte ranges, following CUDA's dense-array implementation (linked in the source comment). Zero-byte arrays return false. Keep shared-allocationdataidsfor conservative wrapper checks and the #716 broadcast fix.Validation on Julia 1.13.1: The shared GPUArrays aliasing testsuite uses the supplied array type, with nine assertions covering self-aliasing, adjacent and overlapping slices in both orders, independent allocations, mixed element sizes, and empty views. All 18 assertions pass for Array and JLArray through the standard test runner. With this fix and the companion StridedViews #57, all 219 original TensorOperations allocator assertions pass. The JLArrays fix can also be backported to the 0.3 release line.