Repository navigation
Maintainability and bug fixing - #478
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
==========================================
- Coverage 97.81% 97.40% -0.41%
==========================================
Files 34 48 +14
Lines 12368 12078 -290
==========================================
- Hits 12098 11765 -333
- Misses 270 313 +43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares v0.13.2. The full list of changes is in CHANGELOG.md; this is the overview.
What's in it
cellformats.jlandconditional-formats.jlare split intoper-topic files under
src/cellformats/andsrc/conditionalformats/. Most of thediff is moved code; the logic change is about 1,700 lines.
copysheet!sharing its cell cache with the originalIOsourcesetLegendPos/setLegendOverlayRichTextString, a styled string or a cell reference, for bothChartandChartExand the precompile workload covers the common read and write paths: about 1 s for the
first calls in a session rather than about 5.5 s.
include Aqua checks. 7,773
@tests, up from 7,169.Behaviour changes
openxlsx(f, source; mode="rw")no longer saves when the do-block throws.=, and a string value iswritten as a quoted text constant.
XLSXErrorrather than aMethodError.SheetCellRefis now exported.