Repository navigation
Conversation
makeunique! restarted the suffix search at _1 for every duplicate, so a header with N copies of one name built O(N^2) symbols: 10,000 copies of one name took 40 seconds to read, and 20,000 took 149 seconds (CSV 0.10.16: 0.1 seconds). Each name now resumes its search after the last suffix it assigned, as 0.10 did since #955. The names are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 9 9
Lines 5566 5569 +3
=======================================
+ Hits 5332 5335 +3
Misses 234 234 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A header with many copies of one name was quadratic to read.
makeunique!restarted its suffix search at_1for every duplicate, so N copies built O(N²) symbols:0.10 kept the next suffix per name since #955 (a 30k-column file with 10k duplicates); the 1.0 rewrite dropped it. Each name now resumes its search after the last suffix it assigned. Names are unchanged: the new function matched both the 1.1.0 and the 0.10.16 algorithm on 200,000 random name lists full of collisions and
_klook-alikes.Verification:
duplicate column names(the three naming cases from Improve performance of reading files with duplicate column names #955 plus an allocation bound): fails on main (4,000 copies allocate 2.88 GB; bound is 100 MB) and passes here (1.8 MB).julia --project=test --check-bounds=yes -t4 test/runtests.jl: 331,783 passed (Julia 1.12.6).🤖 Generated with Claude Code