Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 96.05% 94.69% -1.36%
==========================================
Files 11 12 +1
Lines 228 264 +36
==========================================
+ Hits 219 250 +31
- Misses 9 14 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT READY FOR REVIEW
The numeric core is now units-free. Unitful and DynamicQuantities support live in package extensions that load with
using Unitful/using DynamicQuantities.Core
UnitfulandDynamicQuantitiesare now weakdeps;PhysicalConstantsandUnitfulAstroare dropped.them.
_ustrip,_velocity_ratio,_spectral_axis_factor) have unitless defaults and are specialized per extension. A plainRealvelocity is still read as km/s, and a unitless axis is still treated as wavelength.
blackbodyis computed in plain floats (last-digit change in its doctest output).SpectrumBaseUnitfulExtspectrumconstructors forQuantityaxes (wavelength, frequency, energy, includingBinnedSpectrum),ustrip(spec),unit(spec),blackbody(::Quantity...).Lengthstretches,Frequency/Energycompress.uconvertconversions of the spectral axis and flux density, powered by UnitfulEquivalences.SpectrumBaseDynamicQuantitiesExtredshift/doppler_shiftandblackbodysupport, plusustrip(spec)anddimension(spec)(DynamicQuantities has no unitobjects).
@inferred redshift/doppler_shiftstill hold.Docs and tests
test/ext/dynamicquantities.jl; doctests now also cover extension docstrings.Caveats and follow-ups
optional Unitful needs DustExtinction to become optional too.
UnitfulEquivalencesstays a hard dependency souconvertworks with onlyusing Unitful. The alternative is a separate["Unitful", "UnitfulEquivalences"]extension, at the cost of requiringusing UnitfulEquivalences.uconvertequivalent for DynamicQuantities yet; it needs its own E = hν = hc/λ and F_ν = F_λ λ²/c implementation.