Skip to content

fix(runtime): block deterministic workspace hook failures - #8

Merged
itstimwhite merged 1 commit into
mainfrom
codex/jov-5492-deterministic-hook
Sep 8, 2026
Merged

itstimwhite merged 1 commit into
mainfrom
codex/jov-5492-deterministic-hook

Conversation

@itstimwhite

Copy link
Copy Markdown

Context

JOV-5492 repeatedly failed the same managed-workspace root guard before an agent session began. Retrying unchanged configuration wasted attempts and concealed the actionable failure.

TL;DR

Block deterministic workspace configuration failures while retaining bounded retries for transient hook failures.

Summary

  • Reuse the existing blocked ledger for after_create EX_CONFIG and exact managed-root rejection diagnostics.
  • Keep failure context and the claim while inputs remain unchanged; preserve existing explicit recovery semantics.
  • Extract the existing terminal classifier into a small module measured by the unchanged CI coverage gate.
  • Cover the observed failure, wrapper forms, transient errors, timeouts, phase boundaries and tracker reconciliation.

Alternatives

  • Do not classify every hook failure as permanent: network and temporary failures must retain bounded retries.
  • No new retry framework, runtime control plane, restart or workspace cleanup is introduced.

Test Plan

  • make -C elixir all: 337 tests, zero failures, six existing skips; classifier coverage 100%.
  • mix test test/symphony_elixir/terminal_failure_test.exs: 11 pass; three new regressions failed before fix.
  • Independent bounded source review: no blockers.

The existing blocked ledger is in-memory. Repair the source/helper before an explicit release or restart.

Reuse the existing terminal failure ledger for after_create configuration
exits and exact managed-root guard diagnostics. Keep transient failures
and timeouts on bounded retries. Extract the classifier so the unchanged
CI coverage gate measures its behavior.

Tests: make all; 337 tests, zero failures, six existing skips. New classifier
coverage 100 percent. Independent bounded review found no blockers.

Co-authored-by: Codex <codex@openai.com>
@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown

JOV-5492

@itstimwhite
itstimwhite marked this pull request as ready for review September 8, 2026 22:26
@itstimwhite
itstimwhite merged commit 3f3e3d5 into main Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant